Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommitBatcher getSectorDeadline should check the earlier PreCommit expiry in the batch #6412

Closed
Tracked by #6185
jennijuju opened this issue Jun 7, 2021 · 0 comments · Fixed by #6416
Closed
Tracked by #6185
Assignees
Labels
area/sealing P1 P1: Must be resolved

Comments

@jennijuju
Copy link
Member

Currently, PreCoomitBatcher and CommitBatcher shares getSectorDeadline.

func getSectorDeadline(curEpoch abi.ChainEpoch, si SectorInfo) time.Time {

however, in additional to deal expirations, commit batcher should also make sure it pushes the aggregation message before any of the sectors is going to expired for MaxProveCommitDuration. Therefore, instead of checking si.TicketEpoch + policy.MaxPreCommitRandomnessLookback CommitBatcher should be checking SectorPreCommitOnChainInfo.PreCommitEpoch + MaxProveCommitDuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sealing P1 P1: Must be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants