Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmdb: fork lmdb-go and apply upstream updates #5345

Open
raulk opened this issue Jan 13, 2021 · 1 comment
Open

lmdb: fork lmdb-go and apply upstream updates #5345

raulk opened this issue Jan 13, 2021 · 1 comment
Assignees

Comments

@raulk
Copy link
Member

raulk commented Jan 13, 2021

Unfortunately the go lmdb binding we're using (https://github.com/bmatsuo/lmdb-go) is unmaintained, and it hasn't been updated to latest lmdb versions. We need to create a fork and update lmdb from 0.9.19 to 0.9.27.

See changelog here: https://github.com/LMDB/lmdb/blob/mdb.RE/0.9/libraries/liblmdb/CHANGES.

It's also possible that we need to apply some freelist fixes, as found by the turbogeth team: https://github.com/ledgerwatch/turbo-geth/blob/master/ethdb/kv_lmdb.go#L31.

Blocks #4992.

@raulk raulk self-assigned this Jan 13, 2021
@raulk
Copy link
Member Author

raulk commented Jan 13, 2021

We might be able to just use https://github.com/ledgerwatch/lmdb-go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant