Disable payment channel manager by default

[rvagg]

On node startup, even for a light node, the payment channel manager starts up and watches the chain for paych-related messages to react to. Payment channels get minimal (to no) use currently on mainnet so we should be safe to introduce a configuration option to disable the payment channel manager and turn it on by default.

See

lotus/node/builder_chain.go

Lines 120 to 126 in 0d1d7c2

	// Service: Payment channels
	Override(new(paychmgr.PaychAPI), From(new(modules.PaychAPI))),
	Override(new(*paychmgr.Store), modules.NewPaychStore),
	Override(new(*paychmgr.Manager), modules.NewManager),
	Override(HandlePaymentChannelManagerKey, modules.HandlePaychManager),
	Override(SettlePaymentChannelsKey, settler.SettlePaymentChannels),

[f8-ptrk]

you mean turn it off by default?

[edit]

its not quite clear what you want as an outcome - it seems its already enabled by default, is it? turning it off by default and intro an option to enable it would make sense

[rvagg]

Yeah, sorry, bad wording - turn it off by default, stop it humming in the background.

A few of us are also discussing how we might trim the code down around the paych functionality, removing most, or even all of it from Lotus.

[f8-ptrk]

removing it from boost was detrimental to the project. what was left of the existing storage market on filecoin got killed. even years later there is no more build in way to pay for retrieval. its a feature that once worked and i am not sure what the reason was/is to remove it