Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChainValidateIndex should validate the actual content of the events and not just match on the number of events #12594

Closed
aarshkshah1992 opened this issue Oct 14, 2024 · 3 comments
Labels
Milestone

Comments

@aarshkshah1992
Copy link
Contributor

aarshkshah1992 commented Oct 14, 2024

See #12450 (comment).

The ChainValidateIndex currently only compares the counts of the events in the Index with the number of events for the epoch in the Index to validate the Indexed events.

However, we should also compare the actual content of the events in the chain state AMT with the Indexed events for a more comprehensive check.

See #12570 and #12571 for exploration of more complete checking.

@BigLep
Copy link
Member

BigLep commented Oct 14, 2024

@aarshkshah1992 : I'm not close to the details, but #12571 is related right?

@rvagg
Copy link
Member

rvagg commented Oct 15, 2024

yes, #12571 is the implementation for lotus-shed, all the hard logic is explored in there so a lot of that code can just be copied, like the original counting code was copied from there

@aarshkshah1992
Copy link
Contributor Author

Closed by #12632.

@github-project-automation github-project-automation bot moved this from 🐱 Todo to 🎉 Done in FilOz Oct 23, 2024
@rjan90 rjan90 moved this from 🎉 Done to ☑️ Done (Archive) in FilOz Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ☑️ Done (Archive)
Development

No branches or pull requests

4 participants