Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deflake TestDeployment test #10824

Closed
raulk opened this issue May 4, 2023 · 0 comments · Fixed by #10829
Closed

Deflake TestDeployment test #10824

raulk opened this issue May 4, 2023 · 0 comments · Fixed by #10829
Assignees
@Stebalien

Comments

@raulk
Copy link
Member

raulk commented May 4, 2023

Notes on deflaking captured in code TODOs:

lotus/itests/eth_deploy_test.go

Line 39 in 554dd2f

client, _, ens := kit.EnsembleMinimal(

@Stebalien Stebalien self-assigned this May 4, 2023
Stebalien added a commit that referenced this issue May 4, 2023
@Stebalien
fix: itest: fix eth deploy test flake
e4897e0 
This fixes the flakyness by:

1. Disconnecting the client from the miner before submitting the
message. That way, we force it to get stuck in the message pool.
2. Removing the logic that asks lotus for the "latest" block. We have
other tests that exercise "latest".

fixes #10824
@Stebalien Stebalien mentioned this issue May 4, 2023
Merged
Stebalien added a commit that referenced this issue May 4, 2023
@Stebalien
fix: itest: fix eth deploy test flake
d7deb9a 
This fixes the flakyness by:

1. Disconnecting the client from the miner before submitting the
message. That way, we force it to get stuck in the message pool.
2. Removing the logic that asks lotus for the "latest" block. We have
other tests that exercise "latest".

fixes #10824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: itest: fix eth deploy test flake filecoin-project/lotus
2 participants
@Stebalien @raulk