From ce27d5fcf22ee763706ebf7c48367e503efc5ea6 Mon Sep 17 00:00:00 2001 From: Phi Date: Mon, 9 Oct 2023 11:17:03 +0100 Subject: [PATCH 1/2] fix: config: update sector lifetime comment Update SectorLifetime duration comment to be in line with FIP-0052: https://fips.filecoin.io/FIPS/fip-0052.html --- documentation/en/default-lotus-miner-config.toml | 2 +- node/config/doc_gen.go | 2 +- node/config/types.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/documentation/en/default-lotus-miner-config.toml b/documentation/en/default-lotus-miner-config.toml index 6f0b2aa7c7a..d021a03af48 100644 --- a/documentation/en/default-lotus-miner-config.toml +++ b/documentation/en/default-lotus-miner-config.toml @@ -523,7 +523,7 @@ # CommittedCapacitySectorLifetime is the duration a Committed Capacity (CC) sector will # live before it must be extended or converted into sector containing deals before it is - # terminated. Value must be between 180-540 days inclusive + # terminated. Value must be between 180-1278 days. # # type: Duration # env var: LOTUS_SEALING_COMMITTEDCAPACITYSECTORLIFETIME diff --git a/node/config/doc_gen.go b/node/config/doc_gen.go index b3df012ea4c..93d911cd318 100644 --- a/node/config/doc_gen.go +++ b/node/config/doc_gen.go @@ -1150,7 +1150,7 @@ required to have expiration of at least the soonest-ending deal`, Comment: `CommittedCapacitySectorLifetime is the duration a Committed Capacity (CC) sector will live before it must be extended or converted into sector containing deals before it is -terminated. Value must be between 180-540 days inclusive`, +terminated. Value must be between 180-1278 days.`, }, { Name: "WaitDealsDelay", diff --git a/node/config/types.go b/node/config/types.go index 78f2d136193..092b1973b15 100644 --- a/node/config/types.go +++ b/node/config/types.go @@ -358,7 +358,7 @@ type SealingConfig struct { // CommittedCapacitySectorLifetime is the duration a Committed Capacity (CC) sector will // live before it must be extended or converted into sector containing deals before it is - // terminated. Value must be between 180-540 days inclusive + // terminated. Value must be between 180-1278 days. CommittedCapacitySectorLifetime Duration // Period of time that a newly created sector will wait for more deals to be packed in to before it starts to seal. From db96bc01430279f2bc4397a59dd746e1d2b10ad0 Mon Sep 17 00:00:00 2001 From: Phi Date: Wed, 11 Oct 2023 16:30:30 +0100 Subject: [PATCH 2/2] Update comment Make clear that 1278 days are applicable in nv21 not before. --- documentation/en/default-lotus-miner-config.toml | 2 +- node/config/doc_gen.go | 2 +- node/config/types.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/documentation/en/default-lotus-miner-config.toml b/documentation/en/default-lotus-miner-config.toml index d021a03af48..a4f9fdfa236 100644 --- a/documentation/en/default-lotus-miner-config.toml +++ b/documentation/en/default-lotus-miner-config.toml @@ -523,7 +523,7 @@ # CommittedCapacitySectorLifetime is the duration a Committed Capacity (CC) sector will # live before it must be extended or converted into sector containing deals before it is - # terminated. Value must be between 180-1278 days. + # terminated. Value must be between 180-1278 days (1278 in nv21, 540 before nv21). # # type: Duration # env var: LOTUS_SEALING_COMMITTEDCAPACITYSECTORLIFETIME diff --git a/node/config/doc_gen.go b/node/config/doc_gen.go index 93d911cd318..a9bc026e13e 100644 --- a/node/config/doc_gen.go +++ b/node/config/doc_gen.go @@ -1150,7 +1150,7 @@ required to have expiration of at least the soonest-ending deal`, Comment: `CommittedCapacitySectorLifetime is the duration a Committed Capacity (CC) sector will live before it must be extended or converted into sector containing deals before it is -terminated. Value must be between 180-1278 days.`, +terminated. Value must be between 180-1278 days (1278 in nv21, 540 before nv21).`, }, { Name: "WaitDealsDelay", diff --git a/node/config/types.go b/node/config/types.go index 092b1973b15..256e86bf6c4 100644 --- a/node/config/types.go +++ b/node/config/types.go @@ -358,7 +358,7 @@ type SealingConfig struct { // CommittedCapacitySectorLifetime is the duration a Committed Capacity (CC) sector will // live before it must be extended or converted into sector containing deals before it is - // terminated. Value must be between 180-1278 days. + // terminated. Value must be between 180-1278 days (1278 in nv21, 540 before nv21). CommittedCapacitySectorLifetime Duration // Period of time that a newly created sector will wait for more deals to be packed in to before it starts to seal.