-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(miner)!: remove DEAL_WEIGHT_MULTIPLIER and its input to QAP calc #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #308 +/- ##
==========================================
+ Coverage 3.53% 3.54% +0.01%
==========================================
Files 592 592
Lines 110759 110757 -2
==========================================
+ Hits 3915 3931 +16
+ Misses 105311 105293 -18
Partials 1533 1533
|
rvagg
force-pushed
the
rvagg/qap-no-dealweight
branch
from
September 6, 2024 04:22
0648748
to
47e808f
Compare
Given that this doesn't actually change the power calculus, the breaking change shouldn't be a huge issue (no need to abstract over different versions, we can just change it everywhere). |
rvagg
force-pushed
the
rvagg/qap-no-dealweight
branch
from
September 10, 2024 11:11
47e808f
to
d1961e0
Compare
Stebalien
approved these changes
Sep 10, 2024
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Oct 14, 2024
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Oct 14, 2024
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Nov 19, 2024
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: filecoin-project/builtin-actors#1573
Ref: filecoin-project/builtin-actors#1574
Test copied across from Rust.
This will have implications for Lotus because of the breaking API change, it'd probably be worth figuring out how much pain that is before merging this.