Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(miner)!: remove DEAL_WEIGHT_MULTIPLIER and its input to QAP calc #308

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 19, 2024

Ref: filecoin-project/builtin-actors#1573
Ref: filecoin-project/builtin-actors#1574

Test copied across from Rust.

This will have implications for Lotus because of the breaking API change, it'd probably be worth figuring out how much pain that is before merging this.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 3.54%. Comparing base (6e096a2) to head (d1961e0).

Files with missing lines Patch % Lines
builtin/v15/miner/policy.go 50.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage    3.53%    3.54%   +0.01%     
==========================================
  Files         592      592              
  Lines      110759   110757       -2     
==========================================
+ Hits         3915     3931      +16     
+ Misses     105311   105293      -18     
  Partials     1533     1533              
Files with missing lines Coverage Δ
builtin/network.go 33.33% <ø> (ø)
builtin/v15/miner/policy.go 41.17% <50.00%> (+41.17%) ⬆️

... and 1 file with indirect coverage changes

@Stebalien
Copy link
Member

Given that this doesn't actually change the power calculus, the breaking change shouldn't be a huge issue (no need to abstract over different versions, we can just change it everywhere).

@rvagg rvagg merged commit dbe511a into master Sep 11, 2024
8 checks passed
@rvagg rvagg deleted the rvagg/qap-no-dealweight branch September 11, 2024 01:13
rvagg added a commit to filecoin-project/lotus that referenced this pull request Oct 14, 2024
rvagg added a commit to filecoin-project/lotus that referenced this pull request Oct 14, 2024
rvagg added a commit to filecoin-project/lotus that referenced this pull request Nov 19, 2024
rvagg added a commit to filecoin-project/lotus that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants