Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ready manager for retrieval provider #739

Merged
merged 1 commit into from
Aug 16, 2022
Merged

use ready manager for retrieval provider #739

merged 1 commit into from
Aug 16, 2022

Conversation

hannahhoward
Copy link
Collaborator

Goals

switch to the ready manager as opposed to raw pubsub for ready in retrieval provider

rvagg
rvagg approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 it doesn't look like there's a risk here of duplicate events being fired but I suppose the more focused tool is the right way to do this.

@hannahhoward hannahhoward merged commit e7b2b38 into master Aug 16, 2022
@dirkmc dirkmc mentioned this pull request Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahhoward @rvagg