Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StorageDealAwaitingPreCommit state #453

Merged
merged 5 commits into from
Nov 24, 2020
Merged

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Nov 20, 2020

Markets side of filecoin-project/lotus#4900

@dirkmc dirkmc marked this pull request as ready for review November 24, 2020 13:37
storagemarket/nodes.go Outdated Show resolved Hide resolved
@nonsense
Copy link
Member

I am still very new to this code, but overall looks good to me!

Co-authored-by: Anton Evangelatov <[email protected]>
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually important to move the new deal state to the bottom of the list -- otherwise you need to write a migration for deal states. It's no worries -- I'll do it for you and merge, just a heads up.

storagemarket/dealstatus.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #453 (856abb6) into master (68ed456) will increase coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   65.01%   65.45%   +0.44%     
==========================================
  Files          46       46              
  Lines        3152     3192      +40     
==========================================
+ Hits         2049     2089      +40     
  Misses        871      871              
  Partials      232      232              
Impacted Files Coverage Δ
storagemarket/types.go 0.00% <ø> (ø)
storagemarket/impl/clientstates/client_fsm.go 85.58% <100.00%> (+1.21%) ⬆️
storagemarket/impl/clientstates/client_states.go 89.93% <100.00%> (+0.96%) ⬆️
storagemarket/impl/providerstates/provider_fsm.go 73.95% <100.00%> (+2.14%) ⬆️
...oragemarket/impl/providerstates/provider_states.go 84.20% <100.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ed456...856abb6. Read the comment docs.

@nonsense
Copy link
Member

nonsense commented Nov 24, 2020

It is actually important to move the new deal state to the bottom of the list -- otherwise you need to write a migration for deal states.

Right, this was going to offset a lot of states, including StorageDealActive, so we would have messed up the state of the client with respect to pretty much all deals. Good catch!

@hannahhoward hannahhoward merged commit 55dff31 into master Nov 24, 2020
@dirkmc dirkmc deleted the feat/await-precommit branch November 25, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants