Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up comments #405

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Tidy up comments #405

merged 1 commit into from
Sep 18, 2020

Conversation

kirk-baird
Copy link
Contributor

What has been done

Just some minor typos in comments :)

Signed-off-by: Kirk Baird <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #405 into master will decrease coverage by 0.75%.
The diff coverage is 89.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   61.97%   61.23%   -0.74%     
==========================================
  Files          43       43              
  Lines        3008     2672     -336     
==========================================
- Hits         1864     1636     -228     
+ Misses        987      880     -107     
+ Partials      157      156       -1     
Impacted Files Coverage Δ
retrievalmarket/impl/client.go 65.34% <ø> (-2.12%) ⬇️
retrievalmarket/impl/provider.go 76.11% <ø> (-0.87%) ⬇️
retrievalmarket/types.go 41.47% <ø> (-0.90%) ⬇️
storagemarket/impl/client.go 1.60% <0.00%> (-1.29%) ⬇️
storagemarket/impl/provider.go 1.66% <0.00%> (-1.33%) ⬇️
storagemarket/impl/clientutils/clientutils.go 75.00% <66.67%> (-4.31%) ⬇️
retrievalmarket/network/libp2p_impl.go 82.61% <100.00%> (+0.39%) ⬆️
storagemarket/impl/clientstates/client_states.go 88.29% <100.00%> (-1.08%) ⬇️
storagemarket/impl/providerstates/provider_fsm.go 90.91% <100.00%> (ø)
...oragemarket/impl/providerstates/provider_states.go 83.71% <100.00%> (-1.01%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64f78f7...cbb5c1d. Read the comment docs.

@hannahhoward
Copy link
Collaborator

Thank you!

@hannahhoward hannahhoward merged commit ccb2cbf into filecoin-project:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants