Remove passthrough methods #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
feat/remove-passthrough-methods
branch
from
2af52e9
to
ee0af75
Compare
remove passthrough methods that serve no other purpose than to round trip a call through the node
hannahhoward
force-pushed
the
feat/remove-passthrough-methods
branch
from
ee0af75
to
256c9f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
We have these two methods that have never made any sense to me and I think are not used -- basically -- they just call the node, then return the values back. It seems like it makes way more sense for these methods to just live on the node itself, if they're neccesary (I think they're not in use FWIW). This also removes any reference to market actor existing deal state, which is important for the purposes of the actors upgrade.
Implementation
Remove the methods, node adapter methods, and unused types