Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filestore: use filepath pkg, track close err, lints #20

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Conversation

jsign
Copy link
Contributor

@jsign jsign commented Dec 19, 2019

Some minors while reading this pkg, most relevant:

  • use filepath to rely on stdlib
  • since Store codeflow is simple enough, we can avoid defer to go the extra mile to see if closing fails.

@mishmosh
Copy link
Collaborator

Thank you for this! We will review in the new year.

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM by me.

Please rebase so we can merge

@jsign
Copy link
Contributor Author

jsign commented Jan 2, 2020

Done.
Seems that in the meantime some other commit leveraged the filepath package, so that isn't a new change anymore. (So updated the commit msg).

@hannahhoward hannahhoward merged commit 86ecc3c into filecoin-project:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants