Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly explain how to turn off multicore SDR as soon as the update (assumed v1.10.0) is released #894

Closed
f8-ptrk opened this issue Jun 11, 2021 · 2 comments · Fixed by #995
Assignees
Labels
need/analysis Has been looked at, but not deeply. Needs further research. May need community/maintainer input. P1 High: Likely tackled by core team if no one steps up

Comments

@f8-ptrk
Copy link
Contributor

f8-ptrk commented Jun 11, 2021

see: filecoin-project/lotus#6450

this will flip the logic on how multicore SDR is used. from opt in to opt out.

please make sure the documentation is up to date with this change as soon as the update gets released.

multicore SDR doesn't improve speed on all processors and especially early setups designed for single core processing will see decreasing PC1 speed if they do not opt out

@f8-ptrk f8-ptrk added feature-request need/triage Needs initial labeling and prioritization labels Jun 11, 2021
@johnnymatthews johnnymatthews added need/analysis Has been looked at, but not deeply. Needs further research. May need community/maintainer input. P1 High: Likely tackled by core team if no one steps up status/ready and removed feature-request need/triage Needs initial labeling and prioritization labels Jun 16, 2021
@johnnymatthews johnnymatthews added this to the Week 24, 2021-06-16 milestone Jun 16, 2021
@yusefnapora
Copy link
Contributor

This is the only mention of multicore SDR I could find in a quick grep through the docs site: https://docs.filecoin.io/mine/lotus/seal-workers/#task-resource-table

Seems like it could also go into https://docs.filecoin.io/get-started/lotus/installation/#build-and-install-lotus

@f8-ptrk is there a simple criteria we can give for whether to opt out? e.g. "if your processor doesn't support instruction XYZ, you should set this flag to opt out".

@f8-ptrk
Copy link
Contributor Author

f8-ptrk commented Jun 16, 2021

if a processor doesn't have more then 1 core per CCD --> AMD 7f32 (if you look at the PL test setup - the one they aare using there for PC1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/analysis Has been looked at, but not deeply. Needs further research. May need community/maintainer input. P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants