Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate and integrate CAR bundle #4

Closed
12 tasks done
raulk opened this issue Feb 24, 2022 · 2 comments · Fixed by #6
Closed
12 tasks done

generate and integrate CAR bundle #4

raulk opened this issue Feb 24, 2022 · 2 comments · Fixed by #6
Assignees
Labels
Milestone

Comments

@raulk
Copy link
Member

raulk commented Feb 24, 2022

This issue tracks work being carried out in the raulk/initial branch of this repo:

  • Remove reliance on wasm-builder from all actors
  • Remove reliance on runtime-wasm feature from all actors.
  • Compile actors to Wasm under the bundle module.
  • Create a bundling utility to pack Wasm bytecode into a CAR with an index data structure enumerating actor types => CodeCID.
  • Integrate bundling utility into build.
  • Remove all knowledge of static CodeCIDs from actors, and migrate to an actor::is_builtin_actor syscall that returns whether a given CodeCID corresponds to a builtin actor, and to which from an enumerated set.
  • Load bundle CAR in ref-fvm conformance tests.
  • Pass index structure to the FVM via contructor so it can handle the above syscalls.
  • Run conformance tests.
  • Do the same in Lotus.
  • Publish cargo releases of fvm, fvm_shared, and other modules so we can specify versions in the Cargo.toml file instead of local paths.
  • Make a release of builtin-actors/bundle, so it can be integrated upstream.
@jennijuju
Copy link
Member

next item is in lotus hand now

@raulk
Copy link
Member Author

raulk commented Mar 15, 2022

Bundle is now integrated into Lotus via the FFI layer, for practical reasons. Namely: the fil_builtin_actors_bundle crates exports the CAR as a byte slice for easy consumption by other Rust crates (i.e. filecoin-ffi).

@raulk raulk closed this as completed Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants