Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve stalled retrieval requests from network indexers #1432

Closed
jacobheun opened this issue May 8, 2023 · 0 comments · Fixed by #1425
Closed

Resolve stalled retrieval requests from network indexers #1432

jacobheun opened this issue May 8, 2023 · 0 comments · Fixed by #1425
Assignees
Labels

Comments

@jacobheun
Copy link
Contributor

jacobheun commented May 8, 2023

Summary

Update Boost to handle LegsVoucher graphsync requests via the new, unpaid graphsync retrieval pathway rather than falling back to the legacy code path, so that indexers are able to more reliability ingest advertisements and avoid performance impacts on Boost.

Background

In Boost 1.7.0 we released sector monitoring checks for index integrity. This unfortunately had a bug that could accidentally mark a sector as removed. The fix for this was released in Boost 1.7.1.

The side effect for this was that it resulted in the need for indexers to re-ingest advertisement chains for users going from 1.7.0 to 1.7.1 or later. This increase in retrievals from indexers led to an increase in stalled retrieval. While we significantly improved performance in unpaid graphsync retrievals in Boost 1.6.1, the indexer currently uses a LegsVoucher that causes retrieval for indexers to fallback to the legacy retrievals paths - which can result in issues like #1125 and its linked related issues.

The stalled retrievals here, also prevent the indexers from fully ingesting the records, causing end user retrieval discovery to be unreliable as a consequence. Stabilizing these retrievals should improve both end to end retrievability, and reduce performance impacts from stalled retrievals in Boost.

@jacobheun jacobheun added this to Boost May 8, 2023
@jacobheun jacobheun moved this to In Progress in Boost May 8, 2023
@jacobheun jacobheun self-assigned this May 8, 2023
@jacobheun jacobheun added kind/bug Kind: Bug area/retrieval Area: Retrieval area/indexing and removed kind/bug Kind: Bug labels May 8, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Boost May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants