FIP-0076: make aggregate proof type parameter an option, absent if not aggregating #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle,
raulk and
jsoares
as code owners
arajasek
approved these changes
Feb 1, 2024
Stebalien
approved these changes
Feb 1, 2024
Stebalien
reviewed
Feb 1, 2024
| @@ -186,8 +186,8 @@ struct ProveCommitSectors3Params { | |||
| // Aggregate proof for all sectors. | |||
| // Exactly one of sector_proofs or aggregate_proof must be non-empty. | |||
| AggregateProof: []byte, | |||
| // The proof type for the aggregate proof (ignored if no aggregate proof). | |||
| AggregateProofType: RegisteredAggregateProof, | |||
| // The proof type for the aggregate proof (must be absent if no aggregate proof). | |||
There was a problem hiding this comment.
Hm. Actually, this should probably say "must be null".
There was a problem hiding this comment.
I've left this as a future-proof comment. It's true that today there must be no aggregate proof, but that's the true cause of the constraint.
jennijuju
approved these changes
Feb 2, 2024
rvagg
added a commit
to filecoin-project/go-state-types
that referenced
this pull request
Feb 6, 2024
…ProveReplicaUpdates3Params Ref: filecoin-project/FIPs#934
rvagg
added a commit
to filecoin-project/go-state-types
that referenced
this pull request
Feb 7, 2024
…ProveReplicaUpdates3Params Ref: filecoin-project/FIPs#934
magik6k
pushed a commit
to filecoin-project/go-state-types
that referenced
this pull request
Feb 8, 2024
…ProveReplicaUpdates3Params Ref: filecoin-project/FIPs#934
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented in filecoin-project/builtin-actors#1511