Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin at risk of deprecation #89

Open
sympatheticmoose opened this issue Dec 6, 2023 · 9 comments
Open

Plugin at risk of deprecation #89

sympatheticmoose opened this issue Dec 6, 2023 · 9 comments

Comments

@sympatheticmoose
Copy link

Hi there from Grafana Labs 👋

Firstly, thank you for contributing to the Grafana plugin ecosystem.

I'm reaching out as this plugin is at risk of being deprecated from the Grafana plugin catalog as it depends on Angular (#88) and has not been updated in a number of years.

We recognise that priorities change and that it may no longer be possible to keep plugins up to date. For your awareness, deprecation has no impact on existing users of the plugin, but discourages further adoption to prevent users from starting to rely on a component which won't receive updates.

Please advise if you plan to migrate this plugin or that you agree the plugin should be deprecated. In the case of the latter, if there is any specific guidance you would like to offer users of the plugin - please let me know and we can include this in the deprecation notice.

Feel free to email me at [email protected] if preferred; apologies, we don't have an email address associated with this plugin so I had to raise an issue.

If we don't hear from you within 30 days, I'll go ahead and deprecate the plugin.

Thank you again
David

@retzkek
Copy link
Contributor

retzkek commented Dec 14, 2023

Hi @sympatheticmoose thanks for letting us know about the pending deprecation and sorry for letting this lag so much. We do have someone (@LTrestka) looking at this now at least to get dependencies updated and remove any vestigial traces of Angular (the plugin was completely rewritten early on when React plugins were first released and as I recall annotations at least were still Angular-based).

We're also revisiting the idea of converting it to a backend datasource (#34) instead. Actually, could we do that under the same name or would that need to be a new plugin?

@sympatheticmoose
Copy link
Author

Hey @retzkek no worries - and it's great to hear that you're working on this, if you hit any issues or have questions, come find us in our slack or the forum.

There's no reason why you can't publish under the same name. If it's a breaking change from a user perspective then you'd definitely need to at least bump major version.

I'd also strongly suggest attempting to migrate to create-plugin rather than using toolkit. We have a command which does this and guidance here.

@valdemarpavesi
Copy link

Thanks, yes we are looking to use the updated React version.
image

@LTrestka
Copy link

LTrestka commented Feb 2, 2024

The plugin update is almost complete, there are a few areas that still need to be modified to support react but I should have those done in the next week or so.

@LTrestka
Copy link

Just to provide everyone with an update, there has been a delay in getting an updated release out as the updated plugin is running into the same issue reported here. Unfortunately, this is manifesting itself on both the dev and production builds, so this issue will need to be addressed prior to a new release.

@retzkek and I are looking into this.

Any notes or tips from the community would also be greatly appreciated :)

@sympatheticmoose
Copy link
Author

@LTrestka if you can push the react port to a public branch @briangann might be able to suggest something, he's done a lot of angular-react ports.

@tjdavey
Copy link

tjdavey commented Feb 27, 2024

@LTrestka if you can push the react port to a public branch @briangann might be able to suggest something, he's done a lot of angular-react ports.

@sympatheticmoose I believe @LTrestka has been contributing to a branch on his fork of this project here: https://github.com/LTrestka/graphql-datasource/tree/new-version

@retrodaredevil
Copy link
Contributor

I wanted to give a shameless plug of what I've been working on: Wild GraphQL Data Source and the forum post about it.

It's a brand new plugin, unaffiliated with this plugin. I'm hoping to get Grafana to approve it soon. It's currently waiting for approval in the review process. Approved or unapproved, I figured people following this thread might want to check it out. Please try to keep discussion about Wild GraphQL Data Source either in the issues section there, or in the forum post I linked above.

I figured it would be appropriate commenting on this issue now since there hasn't been any activity here in a while.

@tjdavey
Copy link

tjdavey commented Apr 7, 2024

To provide another alternative, given @retrodaredevil's post. We found that the Grafana Infinity Data Source supports GraphQL and supported all the existing scenarios supported by the fifemon GraphQL Data Source in addition to support for alerting, public dashboards etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants