Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding logic causes discrepancies between the requested amount in the GitHub issue and the displayed value on Allocator.tech. #106

Open
lksbrssr opened this issue Feb 6, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@lksbrssr
Copy link

lksbrssr commented Feb 6, 2025

Specifically, in this issue 3360 GiB were requested. Allocator.tech imported this as 3.28 TiB. However, it's actually 3.28125 TiB. That means there was not enough datacap available on the wallet for the entire dataset. Ideally just roundup all values appropriately.

@kacperzuk-neti kacperzuk-neti added the bug Something isn't working label Feb 6, 2025
@kacperzuk-neti
Copy link
Collaborator

I see that it was imported into Allocator.tech correctly - it shows 3360 GiB here: https://allocator.tech/application/filplus-bookkeeping/web3mine-AG/f3sr34hglqizgdo4pxeftytyl5t65ut7wwi3uksn7owbrh7syelyaierirqh54ojdsnue433ceiuq67eumuezq .
So the bug is most likely in processing input from the allocator when he tells how much to allocate.
@Filip-L please check if you can reproduce it. If yes, then I think the fix is to keep the unit specified by the allocator.

@Filip-L
Copy link
Collaborator

Filip-L commented Feb 10, 2025

@lksbrssr Thank you for your report. The issue has been resolved, and from now on, the data will be displayed and processed using the same unit provided by the Allocator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants