From da38d54ba4518d3e44c92a07c700b353cfe11518 Mon Sep 17 00:00:00 2001 From: stdevYuniers Date: Sun, 20 Jan 2019 12:46:28 -0500 Subject: [PATCH] [docker] refs #27 Fixed a misspell --- docker/images/dev-cli/README.md | 11 +++++++---- docker/images/dev-cli/hooks/push | 6 +++--- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/docker/images/dev-cli/README.md b/docker/images/dev-cli/README.md index 3ac5bcea..41560be8 100644 --- a/docker/images/dev-cli/README.md +++ b/docker/images/dev-cli/README.md @@ -99,18 +99,21 @@ $ docker build --build-arg IMAGE_FROM=$IMAGE_FROM \ -t "$IMAGE_NAME" . ``` -If you want use Visual Studio Code as IDE, yo can change `IMAGE_FROM` to build it. **When base image use Visual Studio Code, you can use `VS_EXTENSIONS` build arg** +If you want use Visual Studio Code as IDE, you can change `IMAGE_FROM` to build it. **When base image use Visual Studio Code, you can use `VS_EXTENSIONS` build arg** ```sh $ git clone https://github.com/simelo/libskycoin-dotnet.git && cd libskycoin-dotnet -$ IMAGE_FROM="simelotech/skycoindev-vscode:develop" +$ git submodule update --init --recursive +$ # Move to vscode folder to avoid file errors with vscode docker image +$ cd gopath/src/github.com/skycoin/skycoin/docker/images/dev-vscode/ +$ IMAGE_FROM="skycoin/skycoindev-vscode:develop" $ SOURCE_COMMIT=$(git rev-parse HEAD) $ IMAGE_NAME=simelotech/libskycoin-dotnet:vscode $ DOCKERFILE_PATH=docker/images/dev-cli/Dockerfile -$ docker build --build-arg IMAGE_FROM=$IMAGE_FROM \ +$ docker build --build-arg IMAGE_FROM="$IMAGE_FROM" --build-arg BDATE=`date -u +"%Y-%m-%dT%H:%M:%SZ"` \ --build-arg SCOMMIT=$SOURCE_COMMIT \ --build-arg VS_EXTENSIONS="ms-vscode.Go windmilleng.vscode-go-autotest" \ -f $DOCKERFILE_PATH \ -t "$IMAGE_NAME" . -``` \ No newline at end of file +``` diff --git a/docker/images/dev-cli/hooks/push b/docker/images/dev-cli/hooks/push index da78a470..3ae43b49 100755 --- a/docker/images/dev-cli/hooks/push +++ b/docker/images/dev-cli/hooks/push @@ -3,7 +3,7 @@ docker push $IMAGE_NAME if [ "$CACHE_TAG" == "develop" ]; then - docker push $DOCKER_REPO:dind - docker push $DOCKER_REPO:vscode - docker push $DOCKER_REPO:vscode-dind + docker push "$DOCKER_REPO:dind" + docker push "$DOCKER_REPO:vscode" + docker push "$DOCKER_REPO:vscode-dind" fi