Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error management #95

Open
drahnr opened this issue May 30, 2020 · 2 comments
Open

error management #95

drahnr opened this issue May 30, 2020 · 2 comments

Comments

@drahnr
Copy link
Member

drahnr commented May 30, 2020

Move to thiserror to simplify a few things around errors in the long run. Also deals with the deprecation of description in favour of fmt::Display and such.

@drahnr
Copy link
Member Author

drahnr commented Sep 30, 2020

There is no point in doing this right now, since all errors are impl'd manually already. Change for not too much gain except for losing a few loc.

@drahnr
Copy link
Member Author

drahnr commented Apr 27, 2021

After looking into this as part of #139 there is quite a bit of pain in there. A lot of information is dropped in early stages due to the assumption of static strings carrying sufficent information, which is not true. The error chain should reach down to the level of FFI where we get an error code and that should be bubbled up all the way to ease checking against the API, every layer on-top is really just a nice helper and avoiding extrac churn.

So this is rather urgent, especially to improve the quality of issues being reported in the mid-term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant