Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key to request personality when creating a session #23

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

ManueleSigona
Copy link
Contributor

Proposed Changes

This PR fixes a bug: the key to use a specific personality in the request payload for the API to create a session is currently set to requestModel, while it should be requestedModel. This causes the personality string that we pass to be silently ignored. You can see for example that passing "next-gen" will always start a session with the "talkative-01" personality.

Linked Issues

n.a.

Types of changes

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease
  • I have added/updated the documentation

Further comments

n.a.

@ManueleSigona ManueleSigona requested a review from qati as a code owner October 17, 2024 06:57
@qati qati merged commit f1fc96d into master Oct 24, 2024
1 check passed
@qati qati deleted the fix/personality_key branch October 24, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants