Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance with PEP 518 #747

Closed
marcofavorito opened this issue Feb 10, 2020 · 3 comments
Closed

Compliance with PEP 518 #747

marcofavorito opened this issue Feb 10, 2020 · 3 comments
Assignees
Labels
core enhancement New feature or request

Comments

@marcofavorito
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The project is not compliant with PEP 518

Describe the solution you'd like

Being compliant. That is, specifying the pyproject.toml file to store the build system dependencies.

Describe alternatives you've considered
N/A

Additional context
N/A

@marcofavorito
Copy link
Contributor Author

Given that:

I see two alternatives:

  • leave everything as it is now
  • change the build system (e.g. poetry)

@DavidMinarsch
Copy link
Contributor

Ok thanks, so leave everything as is for now.

@sinoroc
Copy link

sinoroc commented Feb 21, 2020

For info, I believe a pyproject.toml file like the following should be enough to make a setuptools-based project comply with PEP518:

[build-system]
requires = ['setuptools']
build_backend = 'setuptools.build_meta'

without having to make changes to the setup.py and setup.cfg files.

Example: https://github.com/pypa/setuptools/blob/c0154f47121ca107095eb52ca1462c23b7457045/pyproject.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants