Move standard --format into a separate module #340
Comments
|
I am okay with this, and maybe revisit adding it back if we can get it down to a much smaller set of deps. |
|
We should pull the editor plugin authors into this discussion too cc @stephenkubovic thoughts? |
|
yeah, +1 on not including |
|
+1. This should also avoid formatting issues being opened in the linter. |
|
👍 |
|
Here are some real-world measurements with npm3. With Without So it cuts install time in half. And it removes the following dependencies: |
|
I'm okay with removing |
|
\o/ |
|
Also, standard-format is definitely looking for some help. There are lots of ES6 issues that probably require modification of upstream deps, and some attention to reducing the number of dependencies that it pulls in would also improve things a lot. It works great for the tried and true ES5 style JS, but you end up having to work around it for ES6 and react stuff. I'll try to clean up the issues over the next week and document ways people can help out. |
|
👍 I like @yoshuawuyts idea of running |
|
You can print an error otherwise, something like |
|
Never done anything like that before, but I like the idea, with the fallback to a message like @jzaefferer mentioned. |
|
Maybe we can do a |
|
Yes, a hackathon for getting |
|
@feross lmk about a |
|
This is completed now, and in the |
|
Why not just moved it to devDependencies and save the |
|
@tunnckoCore |
|
@watson I know that. And exactly because of that, this will throw to the users and they will install it if they want/use formating. |
|
My CI builds thank you 🙌 |
|
@jden 🚀 |
|
I think keeping |
SGTM. |
|
👍 |
|
@dcousens @bcomnes @tunnckoCore This change is already shipped in |
Currently around ~1/3 of the dependencies are there to support
standard --format. I propose we move that command to a separate modulestandard-formatsince it isn't related to linting and would make standard a lot "lighter" to install.The text was updated successfully, but these errors were encountered: