Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible mitigation for Python smoke flakes #2461

Closed

Conversation

itowlson
Copy link
Collaborator

No description provided.

@itowlson itowlson force-pushed the python-smoke-test-download-woes branch from ba38364 to dc3f6cd Compare April 18, 2024 02:23
@rylev
Copy link
Collaborator

rylev commented Apr 22, 2024

@itowlson what is the status of this PR? I'm not sure why it's marked as a draft.

@itowlson
Copy link
Collaborator Author

itowlson commented Apr 22, 2024

@rylev It's having the tests run on a regular schedule of "when I remember" to see if the flake still happens. I don't have a lot of faith that this will really fix it, but the flake is intermittent enough that it's hard to know if it's made a difference. Shall I close it? I guess there is not much to do except close it for lack of evidence, or merge it and risk the flake coming back - open to people's preferences.

@itowlson
Copy link
Collaborator Author

I got it to flake... but it flaked on Vault not on Python. Fie!

@itowlson itowlson marked this pull request as ready for review July 19, 2024 01:16
@vdice
Copy link
Contributor

vdice commented Dec 16, 2024

@itowlson is this change still something we'd like to get in?

@itowlson
Copy link
Collaborator Author

We've not seen Python smoke flakes for a while, I think, so I'm gonna treat this as "creating the PR scared the tests into behaving" and close it.

No it may not be an accurate mental model of computers but it works surprisingly well...

@itowlson itowlson closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants