Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More forgiving wasi:http version detection #2928

Closed
itowlson opened this issue Nov 19, 2024 · 2 comments
Closed

More forgiving wasi:http version detection #2928

itowlson opened this issue Nov 19, 2024 · 2 comments

Comments

@itowlson
Copy link
Contributor

We detect a couple of supported RCs of wasi:http, plus releases 0.2.0 and 0.2.1. However, the wasi crate (https://docs.rs/wasi/latest/wasi/) has already moved on to 0.2.2, and will presumably move on to 0.2.3 etc. in other minor versions. This means users of the wasi crate in Spin apps have to pin to an exact patch version instead of the 0.13 minor version (see fermyon/leptos-spin#48 (comment)).

What would be the practicalities of enabling all 0.2 versions of wasi:http, present and future?

cc @alexcrichton

@alexcrichton
Copy link
Contributor

Ah yes I had forgotten about the explicit checks that Spin performs around here which will need to be relaxed yeah to support any 0.2.* version

@itowlson itowlson changed the title More forgiving HTTP version detection More forgiving wasi:http version detection Nov 26, 2024
@itowlson
Copy link
Contributor Author

Closed via #2935.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants