Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace os.system call in tarfile creation with subprocess function #547

Open
4 tasks
shreyb opened this issue Mar 4, 2024 · 0 comments
Open
4 tasks

Replace os.system call in tarfile creation with subprocess function #547

shreyb opened this issue Mar 4, 2024 · 0 comments
Labels
cleanup General code cleanup and optimization enhancement New feature or request

Comments

@shreyb
Copy link
Collaborator

shreyb commented Mar 4, 2024

As mentioned in #546, we should start making the code more robust by replacing os.system calls like the one in tarfiles.tar_up() with either call or run from the subprocess module.

So for this particular case:

  • Make the appropriate os.system -> subprocess.run/call substitution in tarfiles.tar_up()
  • There are a few notes in tarfiles.py as to what needs to change with the error handling after the previous item is done. Make those changes.
  • Add to unit tests to make sure this method is still acting correctly
  • Change integration tests in test_full_home.py to observe new error handling
@shreyb shreyb added enhancement New feature or request cleanup General code cleanup and optimization labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup General code cleanup and optimization enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant