Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es5-sham is also required #31

Open
Kidlike opened this issue Feb 23, 2016 · 8 comments
Open

es5-sham is also required #31

Kidlike opened this issue Feb 23, 2016 · 8 comments

Comments

@Kidlike
Copy link

Kidlike commented Feb 23, 2016

Specifically Object.create.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/create

Supported since IE9.

@elantion
Copy link

Yes, it need. I think we should update redme.md.

@elantion
Copy link

Sorry, update.
You don't need to use es5-sham. Fergaldoyle have added polyfill already and comment ' es5-sham version doesn't work in this instance'.

I have fork this repo and make some progress, it seem like working perfect for now.
https://github.com/elantion/angular.js-ie8-builds

@Kidlike
Copy link
Author

Kidlike commented Feb 24, 2016

OK. Fair point.

I actually discovered this when I was trying our app in Firefox 3.6.28 (don't ask why, just kill me now...)

So, based on the mdn docs, Firefox introduced Object.create in version 4.0.

The question then becomes: why doesn't Fergaldoyle's polyfill work for Firefox 3.6.28, but es5-sham does ?

@fergaldoyle
Copy link
Owner

The polyfils target IE8 only so that they can be aggressively applied and override any other shims which may not work as expected, e.g. es5-sham.

I doubt angular itself supports Firefox 3 so this build won't either, it's 2016!

@Kidlike
Copy link
Author

Kidlike commented Feb 24, 2016

It doesn't support ie8 either, but yeah I didn't have any expectations of support.... It's a technical discussion. If you wanna close this for not supported it's fine by me.

@georules
Copy link

I actually discovered this when I was trying our app in Firefox 3.6.28 (don't ask why, just kill me now...)

I think anyone looking at this repo seriously as a solution for their app shares your frustration. We should start a support group w/ weekly meetings.

@elantion
Copy link

My project is required to support IE8, so I have to make a polyfill for angular 1.4. I copy some code from fergaldoyle's repo. It's working good now.
https://github.com/elantion/angular-polyfill
@georules You can make another polyfill too. It's much easier than you think.

@worthy7
Copy link

worthy7 commented Dec 7, 2017

@elantion's solution fixed most of my problems. For some reason es5-shim was seriously breaking things for me, so I excluded it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants