Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on Simple Auth #8

Closed
locks opened this issue Sep 22, 2014 · 4 comments
Closed

Dependency on Simple Auth #8

locks opened this issue Sep 22, 2014 · 4 comments

Comments

@locks
Copy link

locks commented Sep 22, 2014

Why is the dependency on the Simple Auth library not specified in the package.json?
I just did npm install --save-dev ember-cli-simple-auth-token and I expected it to pull in the necessary libraries, but after running ember build I noticed it didn't :P

@jpadilla
Copy link
Contributor

@locks thanks for reporting this, I'll try and get to it today. I'm in the process of rewriting how this is packaged using ember addon <addon-name> and getting some tests done.

@jpadilla
Copy link
Contributor

@locks I've been working into refactoring this to use the new ember-cli's ember addon feature as well as adding tests.

I've created a new branch, refactor with the current progress which seems to be working on an example project. All tests are passing.

I'd like some feedback on it and if you could try it out and report any weird things, that'd be awesome.

@jpadilla
Copy link
Contributor

Just released v0.4.0.

@locks
Copy link
Author

locks commented Oct 18, 2014

@jpadilla I seem to have missed your mention, I'm sorry. I will try v0.4.0 soon and report back any bugs. Thank you for the update :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants