-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.x] [Bug] App does not 'settle' after login in acceptance test #239
Comments
This was a fun one but I figured it out! |
@jpadilla Thoughts? |
That would be correct. Since we want to test the app when the token is valid too. Maybe there could be a config flag that turns off automated expiration handling of tokens. That way, for testing, we could just turn it off since the tokens we use are anyway short-lived dummy tokens. |
Config flag added in #235 |
This was not easy to track down.. |
After upgrading
ember-simple-auth-token
to4.0.2
from3.0.0
, we are facing a weird issue. In our acceptance tests, after login, the app does not reach a settlled state.A call to
getSettledState
gives the following responseThis causing the test suite to just freeze since the promise never resolves. (As it is still waiting for the app to settle down).
I have created an isolated application and a test case that shows this very clearly.
Application: https://github.com/niranjan94/token-settle-test
Test case:
https://github.com/niranjan94/token-settle-test/blob/f1fe3393b91f25c2b7b36e4e72258553c3074562/tests/acceptance/failure-case-test.js#L1-L18
The text was updated successfully, but these errors were encountered: