Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Token Support #211

Closed
kcaulfield94 opened this issue Nov 27, 2017 · 11 comments
Closed

Refresh Token Support #211

kcaulfield94 opened this issue Nov 27, 2017 · 11 comments

Comments

@kcaulfield94
Copy link

So there is a mismatch when installing via npm and when using the direct github link. Via npm, the plugin will try to hit my refresh endpoint but sends the regular token, not the refresh token. This is not the case with a direct install.

Any plan or timeline for getting this up to date in the registry?

Thanks!

@dcyriller
Copy link
Contributor

Hello @jpadilla, thanks for your work on this addon, it is very usefull. I just ran into the same issue described by @kcaulfield94

Would you mind releasing a new version on npm ? (containaing especially this commit)

I can just use master, but using a tagged version would make me feel better. :)

@kcaulfield94
Copy link
Author

Just checking back in for any sort of progress. Is this still maintained @jpadilla ?

Again, thanks!

@jpadilla
Copy link
Contributor

jpadilla commented Dec 8, 2017

Yeah I was hoping to get some time to bring everything up to date before release v3 with #190. Unfortunately I don't think I'll have time to do it soon. Anyone else want to help with that? If not I'll release v3 as is in upcoming days.

@kcaulfield94
Copy link
Author

Are there any pressing issues that would result from releasing v3 as is?

@kcaulfield94
Copy link
Author

kcaulfield94 commented Dec 11, 2017

Also, thanks for the response :) EDIT: after looking at #190 I realize what you're saying. What I am looking for specifically is the separate refresh token when I install from npm.

@dcyriller
Copy link
Contributor

@jpadilla I did a PR to update ESA + ember-{cli,source} versions here: #212 wdyt ?

@kcaulfield94
Copy link
Author

Much Appreciated @dcyriller

@kcaulfield94
Copy link
Author

@dcyriller @jpadilla I saw that this was merged, did this include support for the separate refresh_token? Looks that way?

@jpadilla
Copy link
Contributor

@kcaulfield94 yeah it will, I'm revisiting @knownasilya's last comment #190 (comment) now.

@jpadilla
Copy link
Contributor

Thank you all again! Just released v3.0.0 🎉

@dcyriller
Copy link
Contributor

Thank you @jpadilla !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants