From 1bc493d6c32491cdbf4c934aa3f1527aae87a054 Mon Sep 17 00:00:00 2001 From: Jeldrik Hanschke Date: Thu, 5 Mar 2020 16:09:43 +0100 Subject: [PATCH 1/2] add test coverage --- .travis.yml | 6 ++++-- config/ember-try.js | 48 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 52 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 545479f..1362084 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,8 +3,7 @@ language: node_js node_js: # we recommend testing addons with the same minimum supported node version as Ember CLI # so that your addon works for all apps - - "8" - - "10" + - "6" sudo: false dist: trusty @@ -32,6 +31,8 @@ env: - EMBER_TRY_SCENARIO=ember-beta - EMBER_TRY_SCENARIO=ember-canary - EMBER_TRY_SCENARIO=ember-default + - EMBER_TRY_SCENARIO=ember-simple-auth-2.x NODE_VERSION=8 + - EMBER_TRY_SCENARIO=ember-simple-auth-3.x NODE_VERSION=10 matrix: fast_finish: true @@ -39,6 +40,7 @@ matrix: - env: EMBER_TRY_SCENARIO=ember-canary before_install: + - if [[ $NODE_VERSION ]]; then nvm install ${NODE_VERSION} && nvm use ${NODE_VERSION}; fi - npm config set spin false - npm install -g npm@6 - npm --version diff --git a/config/ember-try.js b/config/ember-try.js index 4d86d31..d03a1a1 100644 --- a/config/ember-try.js +++ b/config/ember-try.js @@ -13,6 +13,9 @@ module.exports = function() { { name: 'ember-lts-2.16', npm: { + dependencies: { + 'ember-simple-auth': '^1.6.0' + }, devDependencies: { 'ember-source': '~2.16.0' } @@ -21,6 +24,9 @@ module.exports = function() { { name: 'ember-lts-2.18', npm: { + dependencies: { + 'ember-simple-auth': '^1.6.0' + }, devDependencies: { 'ember-source': '~2.18.0' } @@ -29,6 +35,9 @@ module.exports = function() { { name: 'ember-lts-3.4', npm: { + dependencies: { + 'ember-simple-auth': '^1.6.0' + }, devDependencies: { 'ember-source': '~3.4.0' } @@ -37,6 +46,9 @@ module.exports = function() { { name: 'ember-lts-3.8', npm: { + dependencies: { + 'ember-simple-auth': '^1.6.0' + }, devDependencies: { 'ember-source': '~3.8.0' } @@ -45,6 +57,9 @@ module.exports = function() { { name: 'ember-lts-3.12', npm: { + dependencies: { + 'ember-simple-auth': '^1.6.0' + }, devDependencies: { 'ember-source': '~3.12.0' } @@ -53,6 +68,9 @@ module.exports = function() { { name: 'ember-release', npm: { + dependencies: { + 'ember-simple-auth': '^1.6.0' + }, devDependencies: { 'ember-source': urls[0] } @@ -61,6 +79,9 @@ module.exports = function() { { name: 'ember-beta', npm: { + dependencies: { + 'ember-simple-auth': '^1.6.0' + }, devDependencies: { 'ember-source': urls[1] } @@ -69,6 +90,9 @@ module.exports = function() { { name: 'ember-canary', npm: { + dependencies: { + 'ember-simple-auth': '^1.6.0' + }, devDependencies: { 'ember-source': urls[2] } @@ -79,6 +103,30 @@ module.exports = function() { npm: { devDependencies: {} } + }, + { + name: 'ember-simple-auth-2.x', + npm: { + dependencies: { + 'ember-simple-auth': '^2.0.0' + }, + devDependencies: { + // minimum ember version supported by ember-simple-auth@2.x + 'ember-source': '~2.16.0' + } + } + }, + { + name: 'ember-simple-auth-3.x', + npm: { + dependencies: { + 'ember-simple-auth': '^3.0.0' + }, + devDependencies: { + // minimum ember version supported by ember-simple-auth@3.x + 'ember-source': '~3.0.0' + } + } } ] }; From d096fccb7bd9cc6b44ae5dd8f0ef2c3e8f33a46c Mon Sep 17 00:00:00 2001 From: Jeldrik Hanschke Date: Thu, 5 Mar 2020 16:34:39 +0100 Subject: [PATCH 2/2] node 6 is not supported by ember-cli-release-tag --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 1362084..1482f8a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,7 +3,7 @@ language: node_js node_js: # we recommend testing addons with the same minimum supported node version as Ember CLI # so that your addon works for all apps - - "6" + - "8" sudo: false dist: trusty @@ -31,7 +31,7 @@ env: - EMBER_TRY_SCENARIO=ember-beta - EMBER_TRY_SCENARIO=ember-canary - EMBER_TRY_SCENARIO=ember-default - - EMBER_TRY_SCENARIO=ember-simple-auth-2.x NODE_VERSION=8 + - EMBER_TRY_SCENARIO=ember-simple-auth-2.x - EMBER_TRY_SCENARIO=ember-simple-auth-3.x NODE_VERSION=10 matrix: