From b893119c6cbc7abc5661f51ea1c35f1a492f5154 Mon Sep 17 00:00:00 2001
From: Sky Feng <im.sky@foxmail.com>
Date: Sun, 20 Dec 2020 11:06:10 +0800
Subject: [PATCH] refine test codes do not skip characters when ignore error is
 true performance improvement

---
 Sky.Data.Csv.Test/Program.cs | 60 +++++++++++++++++++++++-------------
 Sky.Data.Csv/CsvResolver.cs  | 12 ++++----
 2 files changed, 44 insertions(+), 28 deletions(-)

diff --git a/Sky.Data.Csv.Test/Program.cs b/Sky.Data.Csv.Test/Program.cs
index 42bbe78..2838684 100644
--- a/Sky.Data.Csv.Test/Program.cs
+++ b/Sky.Data.Csv.Test/Program.cs
@@ -43,57 +43,73 @@ public override List<String> Serialize(Student data)
 
     class Program
     {
+        private static readonly double MB = 1024 * 1024.0;
+
         static void TestGenericReader()
         {
-            var csvSettings = new CsvReaderSettings();
-            csvSettings.Encoding = System.Text.Encoding.UTF8;
-            var dataResolver = new StudentResolver();
             var csvFiles = new String[] {
-                //@"..\..\TestData.Csv\csv-students.csv",
+                @"..\..\TestData.Csv\csv-students.csv",
             };
+            var csvWriterSettings = new CsvReaderSettings();
+            csvWriterSettings.Encoding = System.Text.Encoding.UTF8;
+            var dataResolver = new StudentResolver();
             foreach (var csvFile in csvFiles)
             {
-                var itemCount = 0;
+                var recordCount = 0;
+
                 var startTime = DateTime.Now;
-                using (var reader = CsvReader<Student>.Create(csvFile, csvSettings, dataResolver))
+                using (var reader = CsvReader<Student>.Create(csvFile, csvWriterSettings, dataResolver))
                 {
                     foreach (var data in reader)
                     {
-                        ++itemCount;
+                        ++recordCount;
                     }
                 }
-                var endTime = DateTime.Now;
-                var ellapsed = (endTime - startTime).TotalMilliseconds;
-                Console.WriteLine("Count: {0}\tTime: {1}ms", itemCount, ellapsed);
+                var ellapsed = (DateTime.Now - startTime).TotalSeconds;
+
+                Console.WriteLine("Count: {0}\tTime: {1}ms", recordCount, ellapsed);
                 Console.WriteLine("======================");
             }
         }
         static void TestSpecificReader()
         {
             var csvFiles = new String[] {
-                @"..\..\TestData.Csv\csv-ms-dos.csv",
-                @"..\..\TestData.Csv\csv-macintosh.csv",
-                @"..\..\TestData.Csv\csv-comma-delimited.csv",
                 //@"..\..\TestData.Csv\csv-bigdata.csv",
+                @"..\..\TestData.Csv\csv-comma-delimited.csv",
+                //@"..\..\TestData.Csv\csv-lumentest2.csv",
+                //@"..\..\TestData.Csv\csv-lumentest3.csv",
+                @"..\..\TestData.Csv\csv-macintosh.csv",
+                @"..\..\TestData.Csv\csv-ms-dos.csv",
+                @"..\..\TestData.Csv\csv-ms-dos-complex.csv",
                 //@"..\..\TestData.Csv\csv-students.csv",
                 //@"..\..\TestData.Csv\longrowdata.csv",
             };
-            var csvSettings = new CsvReaderSettings();
-            csvSettings.Encoding = System.Text.Encoding.UTF8;
+
+            var csvReaderSettings = new CsvReaderSettings();
+            csvReaderSettings.IgnoreErrors = true;
+            csvReaderSettings.Encoding = System.Text.Encoding.UTF8;
+            csvReaderSettings.SkipEmptyLines = true;
+
             foreach (var csvFile in csvFiles)
             {
-                var itemCount = 0;
+                Int32 recordCount = 0, cellCount = 0;
+                var fileSize = new FileInfo(csvFile).Length;
+
                 var startTime = DateTime.Now;
-                using (var reader = CsvReader.Create(csvFile, csvSettings))
+                using (var reader = CsvReader.Create(csvFile, csvReaderSettings))
                 {
                     foreach (var data in reader)
                     {
-                        ++itemCount;
+                        ++recordCount;
+                        cellCount += data.Count;
                     }
                 }
-                var endTime = DateTime.Now;
-                var ellapsed = (endTime - startTime).TotalMilliseconds;
-                Console.WriteLine("Count: {0}\tTime: {1}ms", itemCount, ellapsed);
+                var ellapsed = (DateTime.Now - startTime).TotalSeconds;
+
+                ellapsed = ellapsed == 0 ? 0.000003 : ellapsed;
+                var speed = (fileSize / MB / ellapsed).ToString("0.00");
+                Console.WriteLine("RC: {0,-9}CC: {1,-10}T(s): {2,-11}S:{3}M/s",
+                    recordCount, cellCount, ellapsed, speed);
                 Console.WriteLine("======================");
             }
             Console.WriteLine();
@@ -102,7 +118,7 @@ static void TestSpecificReader()
         static void Main(string[] args)
         {
             TestSpecificReader();
-            TestGenericReader();
+            //TestGenericReader();
         }
     }
 }
\ No newline at end of file
diff --git a/Sky.Data.Csv/CsvResolver.cs b/Sky.Data.Csv/CsvResolver.cs
index 426b5b7..5ed3c27 100644
--- a/Sky.Data.Csv/CsvResolver.cs
+++ b/Sky.Data.Csv/CsvResolver.cs
@@ -44,19 +44,19 @@ public interface IDataResolver<TData>
     /// <typeparam name="TData">The generic type of which objects will be serialized and deserialized.</typeparam>
     public abstract class AbstractDataResolver<TData> : IDataResolver<TData>
     {
-        public abstract TData Deserialize(List<String> data);
-
-        public virtual TData Deserialize(IEnumerable<String> data)
+        public TData Deserialize(IEnumerable<String> data)
         {
             return Deserialize((List<String>)data ?? new List<String>(data));
         }
 
-        public abstract List<String> Serialize(TData data);
-
-        public virtual TData Deserialize(params String[] data)
+        public TData Deserialize(params String[] data)
         {
             return Deserialize(new List<String>(data));
         }
+
+        public abstract TData Deserialize(List<String> data);
+
+        public abstract List<String> Serialize(TData data);
     }
 
     /// <summary>