Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got the same issue as #8
so I look into the render function and I've found that the problem might be with these lines
vue-feather/src/vue-feather.vue
Lines 111 to 115 in cecbf9a
since the content of
svg
is the icon's path, so I try to useinnerHTML
instead and the problem is gone.would it be better to use
innerHTML
of vnode property instead ofh({ template: icon.contents })
?