From f8733cde8bdd79c2a2eb5640edb7a6ff967f3205 Mon Sep 17 00:00:00 2001 From: ex_liangpy4 Date: Wed, 29 Nov 2023 20:41:57 +0800 Subject: [PATCH] update Microwave Oven Application and SDK code after reviewed --- .../microwave-oven-common/src/microwave-oven-device.cpp | 1 + .../microwave-oven-control-server.h | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/microwave-oven-app/microwave-oven-common/src/microwave-oven-device.cpp b/examples/microwave-oven-app/microwave-oven-common/src/microwave-oven-device.cpp index 3521dd1843b056..0f995e33ee613f 100644 --- a/examples/microwave-oven-app/microwave-oven-common/src/microwave-oven-device.cpp +++ b/examples/microwave-oven-app/microwave-oven-common/src/microwave-oven-device.cpp @@ -49,6 +49,7 @@ ExampleMicrowaveOvenDevice::HandleSetCookingParametersCallback(Optional uint8_t reqCookMode; if(cookMode.HasValue()){ reqCookMode = cookMode.Value(); + } else { diff --git a/src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.h b/src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.h index a440c72b6a5902..0d22de2a655001 100644 --- a/src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.h +++ b/src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.h @@ -51,7 +51,7 @@ class Instance : public CommandHandlerInterface, public AttributeAccessInterface * @param aOpStateInstance The pointer of Operational State Instance. * @param aMicrowaveOvenModeInstance The pointer of Microwave Oven Mode Instance. * Note: a MicrowaveOvenControl instance must live relying on an Operational State instance and a Microwave Oven Mode instance, - * caller should be initialized the 2 instances before initializing MicorwaveOvenControl instance. + * caller should be initialized that 2 instances before initializing MicorwaveOvenControl instance. */ Instance(Delegate * aDelegate, EndpointId aEndpointId, ClusterId aClusterId, Clusters::OperationalState::Instance * aOpStateInstance, Clusters::ModeBase::Instance * aMicrowaveOvenModeInstance); @@ -184,8 +184,8 @@ bool IsCookTimeInRange(uint32_t cookTime); /** * @brief Check if the given cooking power is in range * @param powerSetting power setting that given by user - * @param minCookPower the min power setting that defined via zap configuration - * @param maxCookPower the max power setting that defined via zap configuration + * @param minCookPower the min power setting that defined in application level + * @param maxCookPower the max power setting that defined in application level */ bool IsPowerSettingInRange(uint8_t powerSetting, uint8_t minCookPower, uint8_t maxCookPower);