Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagrams not rendered in Jekyll posts #15

Closed
felixvanoost opened this issue Nov 18, 2023 · 0 comments · Fixed by #16
Closed

Diagrams not rendered in Jekyll posts #15

felixvanoost opened this issue Nov 18, 2023 · 0 comments · Fixed by #16
Assignees
Labels
bug Something isn't working

Comments

@felixvanoost
Copy link
Owner

When running jekyll-kroki on a site that contains Jekyll posts, the diagram descriptions in the post Markdown files are not rendered as images:

Diagram description:

```plantuml
skinparam dpi 125
skinparam packageTitleAlignment left

rectangle "Main" {
  (main.view)
  (singleton)
}
rectangle "Base" {
  (base.component)
  (component)
  (model)
}
rectangle "<b>main.ts</b>" as main_ts

(component) ..> (base.component)
main_ts ==> (main.view)
(main.view) --> (component)
(main.view) ...> (singleton)
(singleton) ---> (model)
```

Rendered HTML:

<pre><code class="language-plantuml">skinparam ranksep 20
skinparam dpi 125
skinparam packageTitleAlignment left

rectangle "Main" {
  (main.view)
  (singleton)
}
rectangle "Base" {
  (base.component)
  (component)
  (model)
}
rectangle "&lt;b&gt;main.ts&lt;/b&gt;" as main_ts

(component) ..&gt; (base.component)
main_ts ==&gt; (main.view)
(main.view) --&gt; (component)
(main.view) ...&gt; (singleton)
(singleton) ---&gt; (model)
</code></pre>

jekyll-kroki should render diagrams in all Jekyll document types.

@felixvanoost felixvanoost added the bug Something isn't working label Nov 18, 2023
@felixvanoost felixvanoost self-assigned this Nov 18, 2023
@felixvanoost felixvanoost linked a pull request Nov 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant