-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pressing Ctrl-C while executing a command in PowerShell Core closes tab #221
Comments
What version of pwsh are you using? I just tried the exact same with 6.1.3 but was not able to reproduce this in Fluent Terminal 0.3.1 or current master. |
It's 6.1.3 for me too. It's very possible it's something on my machine. Let me see if I can get a crash dump or something with more information. |
I figured it out! It's not FluentTerminal :). I also use "scoop" (a package manager for Windows) that creates shim exes for the programs that are installed. The issue only reproduces if that shim exe is used. If I use the path directly to the "real" exe, it works fine. I'll close this since it's not really a FluentTerminal issue, but have included my findings as a curiosity to anyone who finds this thread 😝 When using the
When Ctrl-C is pressed, process However, when in FluentTerminal, the process tree is:
When I perform the same action here, again it's process |
Just as an FYI, there is a fix proposed in scoop for this (so that the shim won't cause such bad behaviour): ScoopInstaller/Scoop#3634 |
For some reason, when using PowerShell Core (
pwsh.exe
) in FluentTerminal, pressing Ctrl-C during a long-running command closes the entire tab.pwsh.exe
outside of FluentTerminalpowershell.exe
(non-Core PowerShell) inside FluentTerminalHere's a recording illustrating what I mean (using the on-screen keyboard to illustrate when Ctrl-C is pressed)
It's odd that this only happens in
pwsh.exe
, perhaps there is some interaction between PowerShell Core and the console APIs that isn't properly handled here.Let me know if I can help repro anything or get any more data! I'm a big fan of FluentTerminal so far, looking forward to seeing it develop!
The text was updated successfully, but these errors were encountered: