Skip to content
This repository has been archived by the owner on Sep 11, 2021. It is now read-only.

Consider directing >=10.13.0 users to built-in script #159

Open
jacobq opened this issue Nov 7, 2018 · 2 comments
Open

Consider directing >=10.13.0 users to built-in script #159

jacobq opened this issue Nov 7, 2018 · 2 comments

Comments

@jacobq
Copy link
Collaborator

jacobq commented Nov 7, 2018

The Windows installer for NodeJS now includes an option to install Python and MS VS. Aside from making it easier for systems with older versions of node, what advantages does windows-build-tools have over this new offering?

@refack
Copy link

refack commented Nov 7, 2018

As I mentioned in nodejs/node#22311 (comment), I think the script we wrote for the node installer, and windows-build-tools, have different advantages and a slightly different use case.

IMHO You could simply mention it as as option.

@refack
Copy link

refack commented Nov 28, 2018

Just FTR this project is great inspiration for how to get a build toolchain for Windows installed without friction (I'm assuming Microsoft has used the feedback generated here to improve their out-of-the-box experience).

The people involved with Node.js support for Windows definatly did, and admittedly it's hard to get this one right.

Update on where we are at right now - we have two fairly decent suggestions:

  1. Install the MS VS2017 Community Edition as described in doc: updating vs cpp build tool installation steps in building nodejs/node#24462 (comment)
    (The "Visual C++ build tools" workload + the "Python 2" and "Git for Windows" individual components)
  2. The new install_tools.bat from win: do not use Boxstarter to install tools nodejs/node#24677
    Which is just: Install chocolatey, and run choco upgrade python2 visualstudio2017-workload-vctools.
    Or in script form:
    "%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe" -NoProfile -InputFormat None -ExecutionPolicy Bypass -Command Start-Process '%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe' -ArgumentList '-NoProfile -InputFormat None -ExecutionPolicy Bypass -Command iex ((New-Object System.Net.WebClient).DownloadString(''https://chocolatey.org/install.ps1'')); choco upgrade -y python2 visualstudio2017-workload-vctools; Read-Host ''Type ENTER to exit'' ' -Verb RunAs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants