Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Three.js revision 82 #5

Open
spinjam opened this issue Dec 17, 2016 · 1 comment
Open

Problem with Three.js revision 82 #5

spinjam opened this issue Dec 17, 2016 · 1 comment

Comments

@spinjam
Copy link

spinjam commented Dec 17, 2016

When used with three.js revision 82, the "TrackballControls" is not loaded:
"Uncaught TypeError: THREE.TrackballControls is not a constructor"

@felixpalmer
Copy link
Owner

The change to THREE.js recently changed the entire codebase to use modules, which means that it is currently not so simple to include code from examples (https://github.com/mrdoob/three.js/tree/dev/examples/js). Basically, you can no longer do THREE.TrackballControls = ...., which is what is breaking amd-three.js. More discussion on this here: mrdoob/three.js#9562

A quick fix is just to remove the TrackballControls from the project, or rename it to not be under the THREE namespace.

I'll do my best to fix this in the future, but it may take a little while. If you can get it working, I'd be very grateful for a pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants