Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[express] Make ExpressAdapter fields protected instead of private #626

Closed
RedbeanGit opened this issue Sep 13, 2023 · 3 comments · Fixed by #625
Closed

[express] Make ExpressAdapter fields protected instead of private #626

RedbeanGit opened this issue Sep 13, 2023 · 3 comments · Fixed by #625

Comments

@RedbeanGit
Copy link
Contributor

Hi, it make it difficult to extends the ExpressAdapter provided because of private fields. Why not use protected fields instead?
@RedbeanGit RedbeanGit mentioned this issue Sep 13, 2023
Merged
@felixmosh
Copy link
Owner

Hi, what is the usecase?

@RedbeanGit
Copy link
Contributor Author

I just want to create my own adapter based on your ExpressAdapter.

@felixmosh
Copy link
Owner

Yeah, I understand that, but what do you want to change, but use the base class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[express] Make ExpressAdapter fields protected instead of private
2 participants
@felixmosh @RedbeanGit