Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow changing the page title #584

Closed
wants to merge 1 commit into from

Conversation

goferito
Copy link
Contributor

Allows changing the page title.

@goferito
Copy link
Contributor Author

@felixmosh The distribution method is a bit new to me. Could you point me in the right direction on how I could use my bull-board fork in my production project? Is it possible to add the dependency of each package from github? Or do I need to publish to my npm account each package (express/ui)?

I tested it using the example.ts provided and seems to pass your validations. Let me know if I can improve something. If we can merge this, I can do the same with the favicon, so the bull board can integrate better into existing projects.

Cheers!

@goferito
Copy link
Contributor Author

If you like the solution I will also update the README with the new feature.

@felixmosh
Copy link
Owner

Hi @goferito thank you for this PR.

In my opinion the change should be much simpler... (be part of the uiConfig) and then passed to ejs as a variable.
(maybe the title should be the same of the value of uiConfig.boardTitle).

WDYT?

@felixmosh felixmosh closed this in 00a122e Jun 16, 2023
@felixmosh
Copy link
Owner

Now the title attribute is synced with uiConfig.boardTitle,
Released in v5.4.0

@goferito
Copy link
Contributor Author

goferito commented Jun 16, 2023

@felixmosh Thanks for the feature. What about the favicon? Could you add support to change that as well? I can give it a try if you want. Maybe also allow the boardTitle to different than the pageTitle? (that was my attempt with my PR)

@felixmosh
Copy link
Owner

felixmosh commented Jun 16, 2023

Yeah, I don't think that we should over complicate this section.... for now there is no good reason to separate between boardTitle & page title.

Regarding favicon, there are several images in the html page... it is possible to add, will you be able to add it?
it should be under uiConfig.favIcon, since there are several images for favIcon, it probably should be an object.

{
  "favIcon": {
    "default": "....favicon.svg",
    "alternative": "...favicon.png"
  }
}

Something like this...
If this is urgent for you, I will more than happy to review a PR. otherwise I will invest some time in next week.
Let's open a new ISSUE to track it

@goferito
Copy link
Contributor Author

I'd love to make a useful contribution. I don't think I can allocate time for this today, but I will take care of it as soon as I have some free time. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants