Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make whole QueueCard clickable #577

Closed

Conversation

paradoxloop
Copy link

Thanks for a great library. I have extended the new Queue Cards by making the whole card clickable rather than just the queue name.

@felixmosh
Copy link
Owner

felixmosh commented Jun 6, 2023

Hi @nicokunz thank you for this PR... it is very welcome :]

This implementation (wrapping div element with a element) is not correct semantically (div can't be inside an a).

I will modify your PR to apply a common trick to overcome this :]
Edit: since the change is not related to files that you've changed, I will push it directly to master & closing this PR.

I really appreciate your time, thank, see you on the next PR 🤗

@felixmosh felixmosh closed this in 5cc1446 Jun 6, 2023
@felixmosh
Copy link
Owner

Released in 5.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants