Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are jobs sorted ascending? #316

Closed
Jivings opened this issue Aug 11, 2021 · 11 comments
Closed

Why are jobs sorted ascending? #316

Jivings opened this issue Aug 11, 2021 · 11 comments

Comments

@Jivings
Copy link
Contributor

Jivings commented Aug 11, 2021

I noticed that recently jobs are sorted asc (6ed2f82)

What's the reason for this? It's strange that on the dashboard I have to go to the final page and then scroll to the bottom in order to see the latest complete job.

image

image

@felixmosh
Copy link
Owner

It is make sense to sort active & failed tabs in asc order, but I agree that completed tab should by sorted in desc

@Jivings
Copy link
Contributor Author

Jivings commented Aug 11, 2021

Maybe this could be an argument to the adapter? I'd much rather have the most recent of every job be the most accessible, as it's usually what I'm interested in.

@felixmosh
Copy link
Owner

Wait, this is what happens right now, the last job that was processed will be at the top of the list (page 1).
I see that in you images, the first job is at page 6 (which makes sense)

Ignore my previous comment, it is not correct.

@Jivings
Copy link
Contributor Author

Jivings commented Aug 12, 2021

Right now the most recent job (added at 15:56:25 today) is on page 6. The oldest job (added at 08/10 17:55:06 - 4 days ago) is at the top of page 1. When you open the queue, page 1 is shown first so I have to click on page 6 and scroll down to the bottom see the most recent job that was processed.

@felixmosh felixmosh reopened this Aug 12, 2021
@felixmosh
Copy link
Owner

Sorry for the inconvenience, I will revert my change.

@felixmosh
Copy link
Owner

Released in v3.5.2

@Jivings
Copy link
Contributor Author

Jivings commented Aug 12, 2021

Thanks so much 🙏

@felixmosh
Copy link
Owner

@Jivings, I think that waiting list should be sorted asc.

WDYT?

@Jivings
Copy link
Contributor Author

Jivings commented Aug 18, 2021

I think since it's FIFO it makes sense to be in desc order, but I get that it might mean the waiting list keeps changing quite rapidly which is not ideal. I think there's not an easy answer, but whichever way they are sorted we should definitely make it clear in the UI - that solves part of the problem.

Perhaps the next step would be to allow the implementer to determine which order they want when they add the queue. How customizable you think these things should be, if at all?

@felixmosh
Copy link
Owner

Maybe it is better to expose a config UI for the queue, so you will able to change the default behavior (it can be part of the dots menu of a queue)

Thank you for the response.

@Jivings
Copy link
Contributor Author

Jivings commented Aug 19, 2021

I have hundreds of queues, so maybe a global behaviour would be good as well, rather than just per queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants