Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: More configuration wait_for_txt #79

Closed
Chippit opened this issue Jun 26, 2024 · 3 comments · Fixed by #80
Closed

Suggestion: More configuration wait_for_txt #79

Chippit opened this issue Jun 26, 2024 · 3 comments · Fixed by #80
Labels
enhancement New feature or request

Comments

@Chippit
Copy link

Chippit commented Jun 26, 2024

As it currently stands, when using a DNS challenge, the role will use the wait_for_txt module with a 2 minute timeout.

In our environment where we have an internal caching DNS server (that also serves important intranet-only addresses that the rest of our playbooks need, on the same domain name), the propagation test generally tends to fail.

It would be convenient to add role variables to:

  • Control the timeout
  • Override the server used by the test, so we can change it to use an upstream server without changing the system DNS server of the ansible controller.
  • Or optionally just disable it entirely.
@felixfontein felixfontein added the enhancement New feature or request label Jun 26, 2024
@felixfontein
Copy link
Owner

Hmm, skipping that step in total is not a good idea, since the ACME server's validation will fail if the records haven't been set up yet.

Making the timeout configurable, and allow to configure the DNS servers used (https://docs.ansible.com/ansible/devel/collections/community/dns/wait_for_txt_module.html#parameter-server) definitely makes sense though.

@felixfontein
Copy link
Owner

I've implemented this in #80.

@Chippit
Copy link
Author

Chippit commented Jun 27, 2024

Thanks so much for the quick fix! This will be very helpful for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants