You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 9, 2022. It is now read-only.
Quotes were needed (but were also insufficient) before 2d12677. After that commit, they actually break those fix commands, causing quotes to be part of arguments seen by the executed commands. As shell is no longer used when executing fix commands, quotes are not consumed by the shell.
Note that none of the plugins that have quotes in fix_cmd also set self.fixable=True, hence commands are not executed by sealert. Quotes need to be removed when affected plugins are marked as fixable.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Multiple plugins contain
fix_cmd
that include quotes, for example:Quotes were needed (but were also insufficient) before 2d12677. After that commit, they actually break those fix commands, causing quotes to be part of arguments seen by the executed commands. As shell is no longer used when executing fix commands, quotes are not consumed by the shell.
Note that none of the plugins that have quotes in
fix_cmd
also setself.fixable=True
, hence commands are not executed bysealert
. Quotes need to be removed when affected plugins are marked as fixable.The text was updated successfully, but these errors were encountered: