Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth refresh method is sync #727

Open
feniljain opened this issue Sep 26, 2024 · 0 comments
Open

oauth refresh method is sync #727

feniljain opened this issue Sep 26, 2024 · 0 comments

Comments

@feniljain
Copy link

Hey team! 👋🏻

I was trying to use SASL OAUTHBEARER for authentication with rust-rdkafka, I found I would have to implement ClientContext with ENABLE_REFRESH_OAUTH_TOKEN true and generate_oauth_token specifically to refresh the token. AWS provides libraries in different languages to generate this token, a few are listed here.

I found this library, aws-msk-iam-sasl-signer that does the same for rust, but it seems generate_oauth_token is a sync method and generate_auth_token method provided by the library is async.

I am raising an issue to understand a point in general, these oauth token generation would almost always be async in general, would it make sense to make changes to make it an async function in trait? Or am I missing something?

@feniljain feniljain changed the title incorrect oauth refresh mechanism oauth refresh method is sync Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant