Add support reading and writing commit metadata. #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadronized
changed the title
|
I’d like to add tests to ensure the feature works as expected; any idea where / how to? |
hadronized
force-pushed
the
feature/commit-metadata
branch
2 times, most recently
from
bbf67fd to
fff9f07
Compare
hadronized
force-pushed
the
feature/commit-metadata
branch
2 times, most recently
from
a1f1549 to
5bf252a
Compare
|
@fede1024 would it be possible to review this and eventually merge / make a release? We are currently using a fork datadog. If there’s anything missing / things you think should be done differently, I’d be more than happy to discuss it! :) |
|
Are strings the right data type here? If the underlying Kafka API takes bytes, I'm inclined to do the same. |
benesch
force-pushed
the
feature/commit-metadata
branch
2 times, most recently
from
2e00b07 to
2392a97
Compare
|
Welp, that experiment failed. Looks like the C library handles arbitrary bytes just fine, but the Kafka protocol expects UTF-8 bytes and something goes very wrong. I'll restore the UTF8-based code. |
|
Thanks @benesch. |
benesch
force-pushed
the
feature/commit-metadata
branch
from
2392a97 to
ec2cc06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.