This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Removing assigning token to params.query for sockets. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 15, 2016
Merged
It was only used to support passing the token via sockets and then normalizing it. It is no longer needed.
ekryski
added a commit
that referenced
this pull request
Feb 15, 2016
Removing assigning token to params.query for sockets. Closes #65.
|
Closes #65. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much thanks to @fastlorenzo for pointing this issue out and providing a PR (#65).
There is actually a bit more code to clean up than was done in his PR so I've continued his work with this one. I also wanted to add a few more automated tests to make sure things are still working.