This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.1.0 of ws just got published.
The version 3.1.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of ws.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Release Notes
3.1.0Features
Bug fixes
CloseEvent.wasClean
was incorrectly set tofalse
forclose codes in the 3000-4999 range (#1146).
Commits
The new version differs by 43 commits.
4e3ada1
[dist] 3.1.0
b320169
[feature] Allow client to specify handshake request timeout (#1177)
5c06c8f
chore(package): update eslint to version 4.3.0 (#1176)
ab6c1c2
[minor] Remove redundant assignments
d781190
chore(package): update eslint to version 4.2.0 (#1169)
16bbddb
[doc] Fix "unware" and "reponse" typos in README.md (#1168)
3544e30
chore(package): update eslint-plugin-import to version 2.7.0 (#1167)
afb36e9
[doc] Fix typos in API docs (#1165)
833766f
chore(package): update eslint-plugin-node to version 5.1.0 (#1155)
034ab89
[ci] Test on node 8
c311c43
[lint] Fix lint issues
0434428
chore(package): update eslint to version 4.1.0 (#1151)
2d4dc08
chore(package): update eslint-plugin-import to version 2.6.0 (#1149)
cd55ced
chore(package): update eslint-plugin-import to version 2.5.0 (#1147)
bb2e952
[fix] Set wasClean to true when close code is in 3000-4999 range (#1146)
There are 43 commits in total.
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴