This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Fixing issue where next is called twice when hitting an unauthenticated service via socket.io #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed service via socket.io
…te and increasing timeout to fix intermittent test failures
|
It looks like the build is failing when trying to install the Maybe that module hasn't been updated to work with Node v5. Want to try setting up the travis.yml to use Node v4.2.2? |
|
Still fails on bcrypt, buffer-util and utf-8-validate modules. The same thing happened with my documentation change earlier this week. |
marshallswain
added a commit
that referenced
this pull request
Dec 20, 2015
Fixing issue where next is called twice when hitting an unauthenticated service via socket.io
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #17 and fixes up some intermittently failing tests.