This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
v0.6 - Bugs fixes, new hooks, and hook tests #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2016
Closed
…al and doesn't come from a service.
| if (Array.isArray(hook.data)) { | ||
| hook.data.forEach(item => { | ||
| setId(item); | ||
| }); |
| @@ -1,23 +1,29 @@ | |||
| import bcrypt from 'bcrypt'; | |||
There was a problem hiding this comment.
After merging this I'll update #113 if necessary
|
Awesome! Just a couple of notes. Then |
This was referenced Mar 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm splitting my local work into two PRs to make it easier to review and migrate to. This one has a bunch of bug fixes, some breaking changes to hooks, and adds a bunch of hook tests.
Changes
idFieldbreaks fromtokenService.create()topopulateUser()after hook #103, Updating User Attached to Params in Client #102, Logging out breaks in React Native #105toLowerCasehook. It already lives in feathers-hooksrequireAuthhook torestrictToAuthqueryWithUserIdhook toqueryWithCurrentUsersetUserIdhook toassociateCurrentUserrestrictToSelfhook torestrictToOwneras it could be used on other resources other than usersrestrictToRoleshook